[PATCH 1 of 2 STABLE] diffhelpers: add canstripcr=True to fix_newline

Yuya Nishihara yuya at tcha.org
Wed Apr 26 07:32:05 EDT 2017


On Tue, 25 Apr 2017 11:23:24 -0700, Jun Wu wrote:
> Excerpts from Yuya Nishihara's message of 2017-04-25 22:56:13 +0900:
> > This will break C API compatibility: new build of diffhelpers.so with old
> > Mercurial. In general, we do rename the C function, but it wouldn't help
> > since there's no try-catch around the call site of fix_newline().
> 
> I don't get it. For "fix_newline" as a Python method exported by
> "diffhelpers.so", it accepts an optional 4th argument. So it'll be fine to
> have new diffhelpers.so with older mercurial python code - the 4th argument
> is set to True by default to maintain the old behavior.

Sorry, I said the opposite thing. It should be old binary + new Mercurial.


More information about the Mercurial-devel mailing list