[PATCH 1 of 2 STABLE] diffhelpers: add canstripcr=True to fix_newline

Phillip Cohen phillip at phillip.io
Wed Apr 26 21:22:37 EDT 2017


I had chatted with Jun about this earlier -- if the most elegant way
is simply to wait for his patch or Yuya's to improve the C module
versioning, which would have to wait until after the freeze anyway,
then this would have to wait too. I'm fine with that since it seems
the most reasonable approach all around and avoids major churn.

And, as you noted, the carriage return sufferers have waited this
long, they can probably wait a little longer.

On Wed, Apr 26, 2017 at 5:58 PM, Durham Goode <durham at fb.com> wrote:
> On 4/24/17 1:29 PM, Jun Wu wrote:
>>
>> This fixes a 4-year bug. I think it is worth being merged.
>
>
> While I'm happy the bug is being fixed, I'm not sure it qualifies for stable
> just a few days before the release. If the bug has been around for 4 years,
> the risk from churning C code is probably greater than the benefit of fixing
> the bug this late in the cycle.
>
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


More information about the Mercurial-devel mailing list