D210: pushvars: move fb extension pushvars to core

[akushner (Aaron Kushner)]

akushner added inline comments.

INLINE COMMENTS

> test-pushvars.t:7
> +  $ cat > $TESTTMP/pretxnchangegroup.sh << EOF
> +  > #!/bin/bash
> +  > env | grep -E "^HG_USERVAR_DEBUG"

Please use /bin/sh

> test-pushvars.t:8-9
> +  > #!/bin/bash
> +  > env | grep -E "^HG_USERVAR_DEBUG"
> +  > env | grep -E "^HG_USERVAR_BYPASS_REVIEW"
> +  > exit 0

I didn't see 'grep -E' in the test base, but do see egrep. Consider this instead:

  env |  egrep "^HG_USERVAR_(DEBUG|BYPASS_REVIEW)" | sort

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D210

To: pulkit, #hg-reviewers
Cc: akushner, mercurial-devel