D210: pushvars: move fb extension pushvars to core

[akushner (Aaron Kushner)]

akushner added a comment.


  @pulkit - see what others say. People might disagree with me on this, but I'd rather be cautious on a feature like this. Even though the variables passed are all prepended with HG_USERVAR so I don't see a way how this could cause problems.

INLINE COMMENTS

> pulkit wrote in commands.py:4012-4016
> Sorry but I don't understand what you mean here. Do I need to change the documentation part or the change the flag part. Currently I have set the default of the flag to True.

I think people might have concerns about sending variables to the server so I think this should be default off and have the documentation tell how to enable it.

I would write the documentation such that the meaning would be "if you want to enable this on your server, add the following"

For reference, I created this feature since I used to use a similar feature in git where you'd do the following convolution:

  git push --receive-pack='env ALLOW_CRAZY_FILENAMES=true git-receive-pack' "

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D210

To: pulkit, #hg-reviewers
Cc: akushner, mercurial-devel