D238: context: rename troubles into instabilities

[indygreg (Gregory Szorc)]

indygreg requested changes to this revision.
indygreg added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> context.py:246-248
> +        """return the list of instabilities affecting this changeset.
> +
> +        Instabilities are returned as strings. possible values are:

This feels like it should be a set not a list.

Should this be changed as part of changing the API?

> exchange.py:694
>                  elif ctx.troubled():
> -                    raise error.Abort(mst[ctx.troubles()[0]] % ctx)
> +                    raise error.Abort(mst[ctx.instabilities()[0]] % ctx)
>  

Why does this only print 1 instability?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D238

To: lothiraldan, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel