D271: obsolete: use bytes() instead of str() so the node is bytes on py3
durin42 (Augie Fackler)
phabricator at mercurial-scm.org
Wed Aug 9 10:24:51 EDT 2017
durin42 marked an inline comment as done.
durin42 added inline comments.
INLINE COMMENTS
> yuja wrote in obsolete.py:587
> Why can't this be just `bytes(prec)` ?
>
> I don't think `str(prec).encode('ascii')` is valid for binary node id.
I swear that didn't work before. But it does work, so yay!
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D271
To: durin42, #hg-reviewers, quark
Cc: yuja, mercurial-devel
More information about the Mercurial-devel
mailing list