D296: extensions: if on py3 and propname is a bytestr, decode as ascii
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Wed Aug 9 11:17:16 EDT 2017
yuja added inline comments.
INLINE COMMENTS
> extensions.py:388
> + if pycompat.ispy3 and isinstance(propname, bytes):
> + propname = propname.decode('ascii')
> assert callable(wrapper)
`pycompat.sysstr()` ?
> extensions.py:401
> raise AttributeError(
> _("type '%s' has no property '%s'") % (cls, propname))
>
Perhaps this shouldn't be bytes. Needs `r''` and drop `_()`.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D296
To: durin42, #hg-reviewers
Cc: yuja, mercurial-devel
More information about the Mercurial-devel
mailing list