quark accepted this revision. quark added a comment. Looks good to me. Bonus point if you can remove `_` so the variable names match the rest of the code. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D328 To: glandium, #hg-reviewers, quark Cc: quark, mercurial-devel