D345: rebase: optimize "source" calculation in adjustdest
quark (Jun Wu)
phabricator at mercurial-scm.org
Fri Aug 11 09:02:07 UTC 2017
quark created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The "source" variable is calculated inside a loop but it does not depend on
loop variables. Therefore move it outside the loop.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D345
AFFECTED FILES
hgext/rebase.py
CHANGE DETAILS
diff --git a/hgext/rebase.py b/hgext/rebase.py
--- a/hgext/rebase.py
+++ b/hgext/rebase.py
@@ -916,12 +916,13 @@
|/ |/
A A
"""
+ # pick already rebased revs from state
+ source = [s for s, d in state.items() if d > 0]
+
result = []
for prev in repo.changelog.parentrevs(rev):
adjusted = dest
if prev != nullrev:
- # pick already rebased revs from state
- source = [s for s, d in state.items() if d > 0]
candidate = repo.revs('max(%ld and (::%d))', source, prev).first()
if candidate is not None:
adjusted = state[candidate]
To: quark, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list