D333: repository: formalize wire protocol interface

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Fri Aug 11 14:27:09 EDT 2017


durin42 added inline comments.

INLINE COMMENTS

> repository.py:59
> +class _basewirecommands(object):
> +    """Client-side interfac for communicating over the wire protocol.
> +

spelling: interfac

> repository.py:217
> +        of results in the order they were called.
> +        """
> +

Probably also note that at the wireprotocol layer, it is known that not all peers stream batch responses, so it may not behave as a streaming response even though it's a generator (specifically ssh behaves this way)

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D333

To: indygreg, #hg-reviewers
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list