D229: phabricator: update diff property even if we choose not to create a new diff

[yuja (Yuya Nishihara)]

yuja added inline comments.

INLINE COMMENTS

> phabricator.py:280
>          diff = creatediff(ctx)
>          writediffproperties(ctx, diff)
>          transactions.append({'type': 'update', 'value': diff[r'phid']})

`writediffproperties()` is called twice. Perhaps one of them should be deleted.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D229

To: quark, #hg-reviewers, durin42
Cc: yuja, mercurial-devel