D366: phabricator: remove an unnecessary writediffproperties call
quark (Jun Wu)
phabricator at mercurial-scm.org
Sun Aug 13 04:41:27 UTC 2017
quark created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This was introduced by https://phab.mercurial-scm.org/D229. Thanks Yuya for finding it!
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D366
AFFECTED FILES
contrib/phabricator.py
CHANGE DETAILS
diff --git a/contrib/phabricator.py b/contrib/phabricator.py
--- a/contrib/phabricator.py
+++ b/contrib/phabricator.py
@@ -277,7 +277,6 @@
transactions = []
if neednewdiff:
diff = creatediff(ctx)
- writediffproperties(ctx, diff)
transactions.append({'type': 'update', 'value': diff[r'phid']})
else:
# Even if we don't need to upload a new diff because the patch content
To: quark, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list