D98: revset: support reading aliases from a .hgrevsets file

mharbison72 (Matt Harbison) phabricator at mercurial-scm.org
Tue Aug 15 00:22:28 EDT 2017


mharbison72 added a comment.


  In https://phab.mercurial-scm.org/D98#4834, @quark wrote:
  
  > It seems to me that a lot of security work (ex. knowing the "origin" when executing a revset, marking config items or sections as safe or unsafe by extensions) are required to be able to turn on this feature by default. If we don't turn this on by default because of security, the `%include ../hgrc` approach seems practical enough already.
  
  
  I thought about doing this, instead of fixing up a stripped down projrc extension.  But then you have to get every developer to edit the local .hg/hgrc file for every clone they have.  So even if we have to have this off by default, I still see value in this in a corporate environment.
  
  I couldn't tell from Yuya's comment if "... not add such revset functions" means don't add support for external revsets at all, or filter them out of this file by default, or something else.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D98

To: indygreg, #hg-reviewers
Cc: durin42, yuja, mharbison72, quark, mercurial-devel


More information about the Mercurial-devel mailing list