D368: releasenotes: add check flag for use of admonitions and its validity
durin42 (Augie Fackler)
phabricator at mercurial-scm.org
Tue Aug 15 13:09:11 EDT 2017
durin42 requested changes to this revision.
durin42 added a comment.
This revision now requires changes to proceed.
A style nit, generally +1 and if you get the style nits handled we should be good to go.
INLINE COMMENTS
> releasenotes.py:266
> + else:
> + ui.write(_("Invalid admonition \'%s\' present in changeset %s\
> +\n") % (admonition.group(1), ctx.hex()[:12]))
nit: in a "-quoted string, you can omit \ on '
not a nit: use
("foo"
"bar")
instead of \ to wrap a multi-line string literal (the concatenation is implicit at module load time).
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D368
To: rishabhmadan96, #hg-reviewers, durin42
Cc: durin42, mercurial-devel
More information about the Mercurial-devel
mailing list