D372: simplemerge: add optional context parameters to simplemerge

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Sat Aug 19 00:53:33 EDT 2017


martinvonz added inline comments.

INLINE COMMENTS

> simplemerge.py:412
> +def simplemerge(ui, localfile, basefile, otherfile,
> +                localctx=None, basectx=None, otherctx=None, repo=None, **opts):
>      def readfile(filename):

Seems unfortunate to have both files and contexts. This is what you mentioned today you will replace by use of "arbitraryfilectx"?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D372

To: phillco, #hg-reviewers
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list