D441: revset: optimize "draft() & ::x" pattern
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Sat Aug 19 03:14:35 EDT 2017
yuja added inline comments.
INLINE COMMENTS
> quark wrote in revsetlang.py:492
> Yes! That's much shorter (I had to copy the trees from debugshell) and more robust (no fragile `len(x) >= 3` handling).
>
> For performance concerns, I think it's fine. Practically, revset parsing is hardly a bottleneck. With chg, `_treecache` could be pre-populated.
I'll rebase my patches then. I'm sure that isn't trivial because I introduced the order flag.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D441
To: quark, #hg-reviewers
Cc: yuja, martinvonz, mercurial-devel
More information about the Mercurial-devel
mailing list