D447: templatekw: choose {latesttag} by len(changes), not date (issue5659)
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Sat Aug 19 12:09:30 EDT 2017
martinvonz added inline comments.
INLINE COMMENTS
> martinvonz wrote in templatekw.py:222
> > This should be enabled only if ptags[0][2] != ptags[1][2].
>
> Good point. Done.
>
> > The latesttagdistance is documented to return the longest path to the latest tag.
>
> I'm not changing latesttagdistance (AFAIK), only the definition of latesttag.
>
> > https://phab.mercurial-scm.org/rHGf04d179124410d491a8def230e408c3b6c98cbfc
>
> Luckily, that's just the commit message and "hg help templates.latesttag" just says "The global tags on the most recent globally tagged ancestor of this changeset" and doesn't define what "most recent" is.
>> This should be enabled only if ptags[0][2] != ptags[1][2].
>
> Good point. Done.
Great point, actually! See updated timings in commit message.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D447
To: martinvonz, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
More information about the Mercurial-devel
mailing list