D358: copytrace: move fb extension to core under flag experimental.fastcopytrace
pulkit (Pulkit Goyal)
phabricator at mercurial-scm.org
Mon Aug 21 07:23:47 EDT 2017
pulkit added a comment.
In https://phab.mercurial-scm.org/D358#7173, @quark wrote:
> For config options, I think it's cleaner if we can unify them:
>
> experimental.copytrace = disable | default | fast
>
>
> - `disable`: no copy tracing
> - `default`: old copy tracing algorithm
> - `fast`: this algorithm
>
> I'm fine with leaving `fastcopytrace.sourcecommitlimit` config options. But if we do want to not introduce them, they could be also folded into `experimental.copytrace` option, like `fast:sourcecommitlimit=100,maxmovescandidatestocheck=200`.
I like the idea of unifying the config, but I was thinking to add a `copytrace` section as there are couple of more flags introduced by copytracing during amend namely `amendcopytrace` and `amendcopytracelimit`. (This is when if we don't want to leave `sourcecommitlimit` and `maxmovescandidatestocheck` options).
If we don't want to introduce these limiting flags, then we can plug the existing things into `experimental` section only.
Also after this and copytracing while amend patches (not send yet) get in, I am thinking to have `hg help -k copytrace` to document these things so that user can understand them.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D358
To: pulkit, #hg-reviewers
Cc: quark, stash, mercurial-devel
More information about the Mercurial-devel
mailing list