D288: bundlerepo: move temp bundle creation to a separate function
krbullock (Kevin Bullock)
phabricator at mercurial-scm.org
Wed Aug 23 14:30:20 EDT 2017
krbullock added inline comments.
INLINE COMMENTS
> martinvonz wrote in bundlerepo.py:322
> I think we usually use a "fn" prefix for function arguments. I think "readfn" would be clearer.
I agree, but as it is, this is simple code movement. Usually we like renames to be done in separate changes. Updating the docstring as @indygreg suggests is appropriate, though.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D288
To: durham, #hg-reviewers, indygreg
Cc: krbullock, martinvonz, indygreg, lothiraldan, mercurial-devel
More information about the Mercurial-devel
mailing list