D468: util: use ~ as a suffix for a temp file in the same directory as a source file

[durin42 (Augie Fackler)]

durin42 added a comment.


  In https://phab.mercurial-scm.org/D468#7908, @smf wrote:
  
  > In https://phab.mercurial-scm.org/D468#7836, @quark wrote:
  >
  > > In https://phab.mercurial-scm.org/D468#7833, @smf wrote:
  > >
  > > > Basically, I'd like a more unified approach for all types of temp files (commit message, histedit, conflicts, etc).
  > >
  > >
  > > I think this patch is about low-level `util` function that shouldn't be coupled with `ui` or config. It has value on its own and I don't think such "unified approach" should block this patch - we can always add configs and make callers of `util.mktempcopy` pass `suffix` down here AFTER this patch.
  >
  >
  > Um, what? That's the whole point of review. Yes, I know you think you can do this AFTER (why are we yelling?). I don't like this patch as-is and am frankly tired of trying to jam stuff through review and promise to clean up later. I am against this patch.
  
  
  As a bystander here, I'm not even sure what the proposals are. Can one of you summarize what the competing ideas are?
  
  (In general I agree with smf that a more unified error-resistant API should be a goal, and I'm -0 on adding complexity to hg in the name of buck performance if there's a better proposal on the table (but if there is I've missed it.))

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D468

To: mbolin, #hg-reviewers, quark, durin42
Cc: smf, mercurial-devel