D492: context: remove unnecessary default values for matchers (API)
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Thu Aug 24 01:08:57 EDT 2017
martinvonz added a comment.
In https://phab.mercurial-scm.org/D492#7991, @dsp wrote:
> if match can't be None, then we should remove it as the default value. Otherwise I look at this in a year and think "why do we not handle a None matcher, when it clearly can be None if the value for match is not set".
Definitely. Good catch.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D492
To: martinvonz, #hg-reviewers, dsp
Cc: dsp, mercurial-devel
More information about the Mercurial-devel
mailing list