D477: revlog: add option to mmap revlog index
mbthomas (Mark Thomas)
phabricator at mercurial-scm.org
Thu Aug 24 10:35:54 EDT 2017
mbthomas added inline comments.
INLINE COMMENTS
> simonfar wrote in test-revlog-mmapindex.t:12-13
> Two things:
>
> 1. Can you add a `ui.debug()` or similar so that you can show that `mmap()` is in use here?
> 2. Can you repeat the test without `mmap()` to show that `mmap()` and not-`mmap()` both still work?
For (1) There's no `ui` object available in the `revlog.revlog` constructor. Is there a way to get one?
For (2), the rest of the test suite will be loading the revlog without mmap, so I didn't think it necessary to test it again here.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D477
To: mbthomas, #fbhgext, indygreg, #hg-reviewers, durin42
Cc: quark, durin42, simonfar, mercurial-devel
More information about the Mercurial-devel
mailing list