D515: phabricator: standardize colors

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Fri Aug 25 00:11:21 EDT 2017


indygreg requested changes to this revision.
indygreg added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> phabricator.py:444
> +        actiondesc = ui.label(_(action), 'phabricator.action.%s' % action)
> +        nodedesc = ui.label(str(ctx), 'phabricator.node')
> +        desc = ui.label(ctx.description().split('\n')[0], 'phabricator.desc')

I suspect Python 3 won't be happy with this. You probably want `bytes()`.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D515

To: quark, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list