D525: rebase: add a changes flag which will tell about the hash changes

quark (Jun Wu) phabricator at mercurial-scm.org
Sat Aug 26 12:14:35 EDT 2017


quark added a comment.


  I think a more general purposed approach is preferred here - see https://phab.mercurial-scm.org/D173. If we make `{changes}` part of the template language (as suggested by the inline comment), the implementation of `{changes}` could be shared across multiple commands.

INLINE COMMENTS

> rebase.py:487-488
> +                fm.startitem()
> +                oldhash = short(repo[oldrev].node())
> +                newhash = short(repo[newrev].node())
> +                fm.write('oldnode', '%s is changed to ', oldhash, label=label)

I think automation may want full hash here. So we might want to allow that somehow.

Maybe we can use template to customize the output, like:

  -T '{changes}' # default
  -T '{changes|"{oldnode|short} -> {newnode|short}"}' # customized entry
  -T '{changes|json}' # json formatted

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D525

To: pulkit, #hg-reviewers
Cc: quark, mercurial-devel


More information about the Mercurial-devel mailing list