D454: releasenotes: view admonition titles using -l flag

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Sun Aug 27 06:03:24 EDT 2017


yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> releasenotes.py:246
> +def _getadmonitionlist(ui, sections):
> +    for section in sections._sections:
> +        ui.write(_(str(section[0]) + ": " + section[1] + "\n"))

Perhaps this can be just `for section in sections` since
`releasenotessections` implements `__iter__`.

> releasenotes.py:247
> +    for section in sections._sections:
> +        ui.write(_(str(section[0]) + ": " + section[1] + "\n"))
> +

Delete `_()`, which is the marker for strings to be translated.

`"%s: %s\n" % ...` should be better for python 3 compatibility.

> releasenotes.py:523
> +
> +    rev = opts.get('rev')
>  

merge error?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D454

To: rishabhmadan96, #hg-reviewers, pulkit, yuja
Cc: yuja, pulkit, mercurial-devel


More information about the Mercurial-devel mailing list