D472: extensions: make wrapfunction() return a context manager

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Mon Aug 28 09:33:02 EDT 2017


yuja added inline comments.

INLINE COMMENTS

> martinvonz wrote in extensions.py:424
> See commit message. It's for compatibility with existing callers that bind the returned value.

I see, but I don't think it's more common than wrapping a plain
function.

If the compatibility matters, we probably shouldn't replace
`wrapfunction` with a context manager.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D472

To: martinvonz, #hg-reviewers, quark, mjpieters
Cc: yuja, lothiraldan, quark, mjpieters, mercurial-devel


More information about the Mercurial-devel mailing list