D464: editor: use an unambiguous path suffix for editor files

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Tue Aug 29 13:38:33 EDT 2017


durin42 added a comment.


  In https://phab.mercurial-scm.org/D464#9054, @mbolin wrote:
  
  > Also, it looks like I would have to refactor `ui.edit()` quite a bit to create a unit test since the file name never escapes the method and that's what you would like me to verify, right?
  
  
  You could do that, but what I'd do is make an "editor" that prints the filename to stderr or something, and then invoke some commands that call that editor to see what the filename is like.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D464

To: mbolin, quark, durin42, #hg-reviewers, ryanmce
Cc: smf, ryanmce, mercurial-devel


More information about the Mercurial-devel mailing list