D347: rebase: rewrite _computeobsoletenotrebased
quark (Jun Wu)
phabricator at mercurial-scm.org
Tue Aug 29 15:11:14 EDT 2017
quark added inline comments.
INLINE COMMENTS
> martinvonz wrote in rebase.py:1494
> Oh, allsuccessors() includes "srcnode" in the output! It took me a while to figure that out. A comment would help.
>
> How about something like this?
>
> successors = list(obsutil.allsuccessors(repo.obsstore, [srcnode]))
> successors = successors[1:] # allsuccessors() includes the start nodes
> if not successors:
> # prune
> ...
That copies the list therefore slightly less performant. I'll add a comment.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D347
To: quark, #hg-reviewers
Cc: martinvonz, mercurial-devel
More information about the Mercurial-devel
mailing list