D348: rebase: change internal format to support destination map

Tue Aug 29 18:05:48 EDT 2017

quark added inline comments.

INLINE COMMENTS

> martinvonz wrote in rebase.py:191-193
> I suppose this was here to allow older versions to write a state file written by a newer client. What will happen after this patch if an older version reads the state file?
> 
> For reference: https://patchwork.mercurial-scm.org/patch/6959/

I think you mean "read" instead of "write".

The old client will crash reading the state file. Even if they do not crash, they cannot figure out what to do correctly because they don't have multi-dest support. So I don't think any attempt to make the format compatible with old client is worthwhile.

Looking at https://phab.mercurial-scm.org/rHG5eac7ab59b95e5c2dc8dd6a268a51c49540fcbeb, https://phab.mercurial-scm.org/rHG92409f8dff5d0d6d0b6c73653b2e356eac5679bc, https://phab.mercurial-scm.org/rHG72412afe4c2872fc3197aeee06f6841c76e19772, the file format has been changed a few times in recent years. So I disagree with Mads Kiilerich and don't think this patch needs change.

If you think perfect compatibility (sane error message) in both directions is a must have, I can add a repo requirement.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D348

To: quark, #hg-reviewers
Cc: martinvonz, mercurial-devel