D527: rebase: move working parent and bookmark for obsoleted revs (BC)

[martinvonz (Martin von Zweigbergk)]

martinvonz added inline comments.

INLINE COMMENTS

> rebase.py:412
> +                else:
> +                    succctx = unfi[succ]
> +                    succdesc = '%d:%s "%s"' % (

Is the use of unfi necessary? Can the successor be hidden? Only if the destination is hidden, it seems.

(And yes, "hg rebase --continue" after "hg --hidden -r ... -d <hidden>" got interrupted will probably fail, but that should be fixed by adding the destination(s) in _setrebasesetvisibility().)

> rebase.py:413-415
> +                    succdesc = '%d:%s "%s"' % (
> +                        succctx.rev(), succctx,
> +                        succctx.description().split('\n', 1)[0])

looks like this can use _ctxdesc(succctx)

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D527

To: quark, #hg-reviewers
Cc: martinvonz, mercurial-devel