D347: rebase: rewrite _computeobsoletenotrebased

[martinvonz (Martin von Zweigbergk)]

martinvonz added inline comments.

INLINE COMMENTS

> rebase.py:1495
> +        if len(successors) == 1:
> +            # obsutil.allsuccessors returns node itself if it finds obsmarkers.
> +            # When the list only contains one element, it means there is at

"returns node itself if it finds obsmarkers" is technically correct, but but also returns it if there are no obsmarkers :-)

However, "When the list only contains one element, it means there is at least one obsmarker with srcnode as predecessor" is not correct; it does not mean that there is at least one obsmarker, it means that there are no successors.

Or did I misunderstand either the text or what allsuccessors() does?

I'll rephrase it in flight unless you tell me soon that I misunderstood.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D347

To: quark, #hg-reviewers
Cc: martinvonz, mercurial-devel