D551: import-checker: allow direct symbol import if the symbol is a module
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Thu Aug 31 10:30:30 EDT 2017
yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.
> In remotefilelog/x.py, it may have:
>
> from . import shallowutils
>
> This triggers "direct symbol import shallowutils from remotefilelog" today.
Perhaps you didn't pass remotefilelog/__init__.py and remotefilelog/shallowutils.py
to import-checker.py. If they are counted as local modules, the error should disappear.
INLINE COMMENTS
> test-imports-checker.t:134
> - testpackage/importsymbolfromsub.py:2: direct symbol import nonmodule from testpackage.subpackage
> testpackage/latesymbolimport.py:3: symbol import follows non-symbol import: mercurial.node
> testpackage/multiple.py:2: multiple imported names: os, sys
This has to be updated to actually test the "direct symbol import".
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D551
To: quark, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
More information about the Mercurial-devel
mailing list