D1557: py3: use encoding.strtolocal() to convert string to bytes

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Fri Dec 1 21:59:52 EST 2017


yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> debugcommands.py:729
> +        ui.write("%c %s %10d %s%s\n" % (ent[0], mode, ent[2],
> +                 encoding.strtolocal(timestr), file_))
>      for f in repo.dirstate.copies():

`timestr` may be either bytes or str. `strtolocal()` should be
applied only to the return value of `strftime()`.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1557

To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list