D1577: localrepo: fix cache repo._filteredrepotypes by adding filtername in key

[yuja (Yuya Nishihara)]

yuja added subscribers: indygreg, quark, yuja.
yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.


  @quark, @indygreg
  
  Is there any practical problem other than the wrong class name?
  
  IIUC, the composed type object shouldn't include a filter name, as it is
  an instance-level property.

INLINE COMMENTS

> localrepo.py:689
> +        unfibase = self.unfiltered().__class__
> +        key = str(self.unfiltered().__class__) + name
>          if key not in self._filteredrepotypes:

Perhaps a tuple of `(cls,  filter name)` is a better key if we have
to create a type object per filter.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1577

To: pulkit, #hg-reviewers, yuja
Cc: yuja, quark, indygreg, mercurial-devel