D821: unamend: move fb extension unamend to core

[yuja (Yuya Nishihara)]

yuja added a comment.


  Can you send a follow-up to fix these issues?

INLINE COMMENTS

> uncommit.py:259
> +    # identify the commit from which to unamend
> +    curctx = repo['.']
> +

Probably better to query `curctx` after locks are taken.

> uncommit.py:280
> +        extras = predctx.extra()
> +        extras['unamend_source'] = curctx.node()
> +

This should be `curctx.hex()`. It's highly discouraged to store blob in extras.

> uncommit.py:311
> +        diff = cm.diff(wm)
> +        changedfiles.extend(diff.iterkeys())
> +

Mostly unused variables?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D821

To: pulkit, #hg-reviewers, durham
Cc: yuja, quark, durin42, ryanmce, singhsrb, durham, mercurial-devel