D1577: localrepo: fix cache repo._filteredrepotypes by adding filtername in key
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Sun Dec 3 04:10:18 EST 2017
yuja added a comment.
In https://phab.mercurial-scm.org/D1577#26858, @quark wrote:
> Yes. I think the proxy class can have all states related to the filter. For example, `unfi.filteredrevcache[filtername]` could be `unfi._filteredrepotypes[typename + filtername]._revcache`.
Sorry I can't see why we need a separate "type" object in this example.
Isn't that effectively a cache of filtered instances?
Anyway, I don't think this patch is the right fix as itself. @pulkit, can you
send a series of patches which really depend on per-filter proxy class?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1577
To: pulkit, #hg-reviewers, yuja
Cc: yuja, quark, indygreg, mercurial-devel
More information about the Mercurial-devel
mailing list