D1577: localrepo: fix cache repo._filteredrepotypes by adding filtername in key

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Mon Dec 4 09:24:32 EST 2017


pulkit added a comment.


  In https://phab.mercurial-scm.org/D1577#26833, @yuja wrote:
  
  > Is there any practical problem other than the wrong class name?
  
  
  There was some problem at the time when I send the patch but that got solved. So no problem apart from that.
  
  > IIUC, the composed type object shouldn't include a filter name, as it is
  >  an instance-level property.
  
  Yes, this part confused me a lot while debugging. When I see what repo object I has, I get `mercurial.localrepo.visiblefilteredrepo` and I assume it's filtered by `visible` filter but later after going through filteredrevs, got to know that the name of type object can be wrong.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1577

To: pulkit, #hg-reviewers, yuja
Cc: yuja, quark, indygreg, mercurial-devel


More information about the Mercurial-devel mailing list