D1598: contrib: ban find(1)'s -printf operator, as it is a GNU-ism

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Tue Dec 5 22:03:35 UTC 2017


durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1598

AFFECTED FILES
  contrib/check-code.py

CHANGE DETAILS

diff --git a/contrib/check-code.py b/contrib/check-code.py
--- a/contrib/check-code.py
+++ b/contrib/check-code.py
@@ -149,6 +149,8 @@
     (r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'"),
     (r'cp.* -r ', "don't use 'cp -r', use 'cp -R'"),
     (r'grep.* -[ABC]', "don't use grep's context flags"),
+    (r'find.*-printf',
+     "don't use 'find -printf', it doesn't exist on BSD find(1)"),
   ],
   # warnings
   [



To: durin42, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list