D1285: repoview: add a new attribute _visibilityexceptions and related API

lothiraldan (Boris Feld) phabricator at mercurial-scm.org
Wed Dec 6 04:49:56 EST 2017


lothiraldan added inline comments.

INLINE COMMENTS

> repoview.py:189
> +    # hidden revs which should be visible
> +    _visibilityexceptions = set()
> +

As `_visibilityexceptions` is defined as a class attribute, mutating it is likely to mutate it for all instances of repoview, I'm not sure if it's the intended behavior.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1285

To: pulkit, #hg-reviewers, quark
Cc: lothiraldan, quark, mercurial-devel


More information about the Mercurial-devel mailing list