D1238: overlayworkingctx: add _manifest, files(), added(), removed(), modified()

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Thu Dec 7 17:12:15 EST 2017


durin42 added inline comments.

INLINE COMMENTS

> context.py:2022
> +
> +        flag = self._flagfunc
> +        for path in self.added():

pyflakes noticed this wasn't used. I'm cleaning it up in flight.

> context.py:2034
> +    @propertycache
> +    def _flagfunc(self):
> +        def f(path):

Which makes me wonder if this method is dead code now. Could you check and send a follow-up if it is in fact dead? Thanks!

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1238

To: phillco, #hg-reviewers, durin42
Cc: mercurial-devel


More information about the Mercurial-devel mailing list