D1246: rebase: do not update if IMM; instead, set the overlaywctx's parents

phillco (Phil Cohen) phabricator at mercurial-scm.org
Fri Dec 8 15:09:11 EST 2017


phillco added inline comments.

INLINE COMMENTS

> dlax wrote in rebase.py:1003
> `wctx` has a default value of `None`, so either it shouldn't have that or there should be a check for `None` here.

Good point -- dropped.

> dlax wrote in rebase.py:1007
> `wctx` is redefined here.

This is intentional.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1246

To: phillco, #hg-reviewers, durin42, dlax
Cc: dlax, mercurial-devel


More information about the Mercurial-devel mailing list