D1245: rebase: pass wctx to rebasenode()

phillco (Phil Cohen) phabricator at mercurial-scm.org
Fri Dec 8 15:10:13 EST 2017


phillco added inline comments.

INLINE COMMENTS

> dlax wrote in rebase.py:995
> Isn't it meant to be used in the function body? I see a `wctx = repo[None]` below, perhaps it should be dropped.
> 
> But this wouldn't work with a `None` default value as mentioned in the next patch.

Yes, it's used in the next patch. But you're right that it's the only callsite, so I've made it non-optional.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1245

To: phillco, #hg-reviewers, durin42, dlax
Cc: dlax, mercurial-devel


More information about the Mercurial-devel mailing list