D1617: rebase: extract _assignworkingcopy

phillco (Phil Cohen) phabricator at mercurial-scm.org
Mon Dec 11 01:32:20 EST 2017


phillco added inline comments.

INLINE COMMENTS

> krbullock wrote in rebase.py:393
> Rather than having this method spookily set self.wctx, why not make `_assignworkingcopy` _return_ the wctx (and rename it accordingly)?

Good point, I'll send a followup.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1617

To: phillco, #hg-reviewers, dlax
Cc: krbullock, mercurial-devel


More information about the Mercurial-devel mailing list