[PATCH 3 of 3] run-tests: accept '\' vs '/' path differences without '(glob)'

Augie Fackler raf at durin42.com
Mon Dec 11 08:48:07 EST 2017


> On Dec 11, 2017, at 00:24, Matt Harbison <mharbison72 at gmail.com> wrote:
> 
> On Sun, 10 Dec 2017 18:28:03 -0500, Augie Fackler <raf at durin42.com> wrote:
> 
>> 
>>> On Dec 10, 2017, at 5:39 PM, Matt Harbison <mharbison72 at gmail.com> wrote:
>>> 
>>> On Sun, 10 Dec 2017 16:48:26 -0500, Augie Fackler <raf at durin42.com> wrote:
>>> 
>>>> 
>>>>> On Dec 10, 2017, at 3:47 PM, Matt Harbison <mharbison72 at gmail.com> wrote:
>>>>> 
>>>>> # HG changeset patch
>>>>> # User Matt Harbison <matt_harbison at yahoo.com>
>>>>> # Date 1512882971 18000
>>>>> #      Sun Dec 10 00:16:11 2017 -0500
>>>>> # Node ID ebc7a05d9389989fc2e81d30fa1c10dd01be9a76
>>>>> # Parent  e1119050f15e2169ac766e6a69eeab70729e9e40
>>>>> run-tests: accept '\' vs '/' path differences without '(glob)’
>>>> 
>>>> series queued, many thanks
>>>> 
>>>> […]
>>>> 
>>>>> It's probably unreasonable to submit a single patch that wipes out all of the
>>>>> (glob) instances that were only used to hide path differences, given the churn
>>>>> from other contributors.  Since their presence isn't harming the tests, these
>>>>> can be removed through attrition.
>>>> 
>>>> You could do it if you wanted with a skip-blame annotation as was done in d92dc725223b. Then we can pass the right filter to `hg annotate` and not see the noop changes. Not a requirement though, don’t feel obligated to do so.
> 
> OK, done.  But 3 of 3 isn't showing up in the mail archive, and at ~290K for that patch, I would have expected a digest email too.  So something choked.  I'll try to check tomorrow around 8:30 EST and resend if needed, before too much more activity occurs.

It probably got stuck in moderation. I'll mod it through.

> 
> Random thought: should these # skip-blame markers also imply a default skip in bisect?  It's probably too late to change the name now...

probably not? It's not a default skip in blame, you have to specify the flag anyway...


More information about the Mercurial-devel mailing list