D1426: logtoprocess: add the possibility to not start a shell

lothiraldan (Boris Feld) phabricator at mercurial-scm.org
Wed Dec 13 04:03:27 EST 2017


lothiraldan added a comment.


  Without `DETACHED_PROCESS`, no console is spawned either with `shell=False` or `shell=True` **but** Mercurial will wait for the log-to-process script to finish before ending.
  
  So I would say to keep `DETACHED_PROCESS`.
  
  The real question is how to do variables expansion with `shell=False`, I don't think that Python has a stdlib function for doing that.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1426

To: lothiraldan, #hg-reviewers, mbthomas
Cc: durin42, yuja, mbthomas, mercurial-devel


More information about the Mercurial-devel mailing list