[PATCH 3 of 3] run-tests: accept '\' vs '/' path differences without '(glob)'

[Martin von Zweigbergk]

I think the problem is in this line from the test (that you changed):

  $ echo "  saved backup bundle to \$TESTTMP\foo.hg" >> test-failure.t

The '\' there probably just needs to be escaped. It seems like at
least dash and tcsh otherwise interpret it (but bash treats it
literally). Proof:

$ dash -c 'echo "  saved backup bundle to \$TESTTMP\foo.hg"'
  saved backup bundle to $TESTTMP
                                 oo.hg

I'll just change the '\f' to '\\f' in flight and we'll see if tests
pass when they run again.

On Tue, Dec 12, 2017 at 10:06 PM, Matt Harbison <mharbison72 at gmail.com> wrote:
>
> On Dec 13, 2017, at 12:40 AM, Martin von Zweigbergk <martinvonz at google.com>
> wrote:
>
> Is it this patch that broke test-run-tests.t? See
> https://buildbot.mercurial-scm.org/builders/hg%20tests/builds/1357/steps/run-tests.py%20%28python%202.7.10%29/logs/stdio.
> I haven't even tried to verify, but Matt and I were both on the blame
> list for the broken build and it didn't seem related to anything I
> did.
>
>
> My guess is that it’s this one:
>
> https://www.mercurial-scm.org/repo/hg-all/rev/fd61bad1a338
>
>
> I noticed the .replace() wasn’t doing anything useful when I tried adding
> the other patterns to common-patterns.py last night. Somehow, it not only
> passed on Windows and Linux for me, it provided the correct output when I
> eliminated the existing output.
>
>
> Maybe try dropping that tuple in run-tests.py, since I don’t think it’s
> needed any more.  Sorry about that.
>
>
>
> On Mon, Dec 11, 2017 at 5:48 AM, Augie Fackler <raf at durin42.com> wrote:
>
>
> On Dec 11, 2017, at 00:24, Matt Harbison <mharbison72 at gmail.com> wrote:
>
>
> On Sun, 10 Dec 2017 18:28:03 -0500, Augie Fackler <raf at durin42.com> wrote:
>
>
>
> On Dec 10, 2017, at 5:39 PM, Matt Harbison <mharbison72 at gmail.com> wrote:
>
>
> On Sun, 10 Dec 2017 16:48:26 -0500, Augie Fackler <raf at durin42.com> wrote:
>
>
>
> On Dec 10, 2017, at 3:47 PM, Matt Harbison <mharbison72 at gmail.com> wrote:
>
>
> # HG changeset patch
>
> # User Matt Harbison <matt_harbison at yahoo.com>
>
> # Date 1512882971 18000
>
> #      Sun Dec 10 00:16:11 2017 -0500
>
> # Node ID ebc7a05d9389989fc2e81d30fa1c10dd01be9a76
>
> # Parent  e1119050f15e2169ac766e6a69eeab70729e9e40
>
> run-tests: accept '\' vs '/' path differences without '(glob)’
>
>
> series queued, many thanks
>
>
> […]
>
>
> It's probably unreasonable to submit a single patch that wipes out all of
> the
>
> (glob) instances that were only used to hide path differences, given the
> churn
>
> from other contributors.  Since their presence isn't harming the tests,
> these
>
> can be removed through attrition.
>
>
> You could do it if you wanted with a skip-blame annotation as was done in
> d92dc725223b. Then we can pass the right filter to `hg annotate` and not see
> the noop changes. Not a requirement though, don’t feel obligated to do so.
>
>
> OK, done.  But 3 of 3 isn't showing up in the mail archive, and at ~290K for
> that patch, I would have expected a digest email too.  So something choked.
> I'll try to check tomorrow around 8:30 EST and resend if needed, before too
> much more activity occurs.
>
>
> It probably got stuck in moderation. I'll mod it through.
>
>
>
> Random thought: should these # skip-blame markers also imply a default skip
> in bisect?  It's probably too late to change the name now...
>
>
> probably not? It's not a default skip in blame, you have to specify the flag
> anyway...
>
> _______________________________________________
>
> Mercurial-devel mailing list
>
> Mercurial-devel at mercurial-scm.org
>
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel