[PATCH 3 of 3] run-tests: accept '\' vs '/' path differences without '(glob)'
Martin von Zweigbergk
martinvonz at google.com
Fri Dec 15 02:11:33 EST 2017
Patch here: https://phab.mercurial-scm.org/D1699
On Thu, Dec 14, 2017 at 10:02 PM, Martin von Zweigbergk
<martinvonz at google.com> wrote:
> On Thu, Dec 14, 2017 at 8:57 PM, Kevin Bullock
> <kbullock+mercurial at ringworld.org> wrote:
>>> On Dec 14, 2017, at 22:55, Martin von Zweigbergk <martinvonz at google.com> wrote:
>>>
>>> Could you point me to the build output?
>>
>> https://buildbot.mercurial-scm.org/builders/hg%20tests/builds/1361/steps/run-tests.py%20%28python%202.7.10%29/logs/stdio
>>
>>> Do you also know which shell is used by it?
>>
>> /bin/sh is dash, but it may be using /bin/bash, not sure.
>
> After some experimentation, I was able to reproduce it. run-tests.py
> actually accepts a --shell option that you can use. However,
> test-run-tests.t calls helper-runtests.sh that unsets the shell, so
> even if you pass --shell=/bin/dash, you only run the test with that
> shell, not the test that is run by the test. So if you comment out the
> relevant line in helper-runtests.sh and pass --shell=/bin/dash, you
> can reproduce it on a machine where /bin/sh is something else (without
> repointing that link).
>
> dash and bash behave differently on `echo '\\\\'`, but I think we can
> switch to printf to make it compatible. I'll work on a patch.
>
>>
>> pacem in terris / мир / शान्ति / سَلاَم / 平和
>> Kevin R. Bullock
>>
More information about the Mercurial-devel
mailing list