D1678: revset: pass pre-optimized tree in revset.matchany()
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Fri Dec 15 08:00:40 EST 2017
yuja added a comment.
> Since we are calling them at each command level, it will be better to call unhidehashlikerevs() in `scmutil.revrange|revsingle`.
I thought about that, but `scmutil.rev*()` would have to return new filtered `repo`
object, which didn't seem nice. And mutating a given `repo` argument has the
original problem, when to discard unhidden revisions. So my conclusion was a
separate function.
> We will still need to store the filtername in dispatch and then later on
> decide on basis of that whether we want to uhide things.
Doesn't each command know whether it should unhide or not?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1678
To: pulkit, #hg-reviewers
Cc: yuja, mercurial-devel
More information about the Mercurial-devel
mailing list