D1703: logtoprocess: connect all fds to /dev/null to avoid bad interaction with pager
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Fri Dec 15 09:11:25 EST 2017
yuja added inline comments.
INLINE COMMENTS
> logtoprocess.py:94
> + # and pager will wait for scripts to end if we don't do that
> + nullrfd = open(os.devnull, 'r')
> + nullwfd = open(os.devnull, 'w')
Better to close these file objects in the parent process, though that wouldn't matter.
As we only need a file descriptor, `os.open(os.devnull, os.O_RDWR)` can be used.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1703
To: lothiraldan, #hg-reviewers
Cc: yuja, mercurial-devel
More information about the Mercurial-devel
mailing list