D1460: workers: add config to enable/diable workers

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Sun Dec 17 14:30:14 EST 2017


indygreg added inline comments.

INLINE COMMENTS

> worker.py:85
>      '''
> -    if worthwhile(ui, costperarg, len(args)):
> +    enabled = ui.configbool('worker', 'enabled', True)
> +    if enabled and worthwhile(ui, costperarg, len(args)):

I updated this line to drop the default value argument, which is not needed when the config item defines a default.

The test harness passed with the original code. The developer warning is emitted at run time. So this tells me that we have 0 test coverage of this workers code :/

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1460

To: wlis, #hg-reviewers, lothiraldan, ikostia, durin42
Cc: indygreg, lothiraldan, mercurial-devel


More information about the Mercurial-devel mailing list